tabvengers / spicy-sections

Creative Commons Zero v1.0 Universal
128 stars 10 forks source link

questions/comments about demo #19

Closed scottaohara closed 2 years ago

scottaohara commented 3 years ago

saw dave's article last night and got to poking around the demo this morning. a couple bits concerning the demo.

davatron5000 commented 3 years ago

Thanks @scottaohara.

  1. I'll look into the aria-expanded on tabs. I wonder if it's a remnant from a bootstrapping setup phase in the code.
  2. It should be keyboard operable. My bookshelf and has a slightly different/older version so maybe we messed something up there.
  3. Seems reasonable! I'll take a look.
bkardell commented 3 years ago

Thanks @scottaohara - sorry @davatron5000... this was (I hope) resolved in PR #13 and the file hosted on glitch was just out of sync - if it is linked to that (I expect it is) that's why.. I've just updated it, just now - let's see where we stand now? what's the codepen link?

bkardell commented 2 years ago

After our meeting today we agreed the first two questions have been resolved, and the third one probably deserves its own issue (perhaps more than one). I have a few issues to open, or if @scottaohara gets to it first, let's please mention that it came from this issue - and I'll close this one in the meantime.