search

tabvengers / spicy-sections

Creative Commons Zero v1.0 Universal
128 stars 10 forks source link

WIP: programmatic tests and some test organization #34

Closed lajja99 closed 2 years ago

lajja99 commented 2 years ago

Adds tests for @bkardell's initial attempt to add a solution for #31 (provide a programatic API) which verify all of the same things when this programatic API is excersized. Since these checks involve much of the same code, there is refactoring of verifications to a shared module which can be reused by all tests.

bkardell commented 2 years ago

This is great, thanks! I guess I should send a PR for the code in #31 and this should depend on it, and we merge that first?

From this, @lajja99 have at least one question we should probably discuss about a particilar aria attribute and how we're handling it... I guess we don't need to sort that out before we merge, it just might change whether 2 lines here should actually be passing or failing.

lajja99 commented 2 years ago

That sounds good @bkardell we can merge this after #31. Thank you for reviewing!