search

tace / jolla2gether

Client app for accessing together.jolla.com site. Implemented with QML for Sailfish.
7 stars 2 forks source link

Default 'G' icon shown for users without specific gravatar avatar #5

Closed keto closed 9 years ago

keto commented 9 years ago

I think this is because the size change function strips out the 'd=' parameter from the gravatar url. So the replace pattern there needs some work.

https://github.com/tace/jolla2gether/blob/3318f8eed338261694d32d4ca6a91bcd77120dbd/qml/pages/UsersModel.qml#L63

https://en.gravatar.com/site/implement/images/

keto commented 9 years ago

Sorry, my mad, it's not about the replace, but probably because the API returns the URL as html encoded, like ?s=48&d=identicon&r=PG

I'll fix this on server side.

Is it ok if I add a new value 'avatar_url' in the user API response with properly formatted URL, with the schema and all? This way we keep it backward compatible with older client versions.

tace commented 9 years ago

Great that the reason found. I wonder how it has changed as it worked before?

But your suggestion about adding 'avatar_url' is fine for me. Will include it to next update.

keto commented 9 years ago

I don't see any changes in our Askbot which would affect this, so my guess is that something changed on gravatar side so that it does not handle the slightly badly formatted requests.

I'll let you know when the server side changes are in.

tace commented 9 years ago

Will the changes be in next week? Just wondering should I still postpone jolla2gether app new version release to wait this?

keto commented 9 years ago

Yes, sorry it has taken so long. I was planning to include also some other fixes to next deployment, but have been busy working on other stuff. I will push it forward tomorrow.