search

tachyons-css / tachyons

Functional css for humans
https://tachyons.io
MIT License
11.63k stars 677 forks source link

Missing/incorrect colours #632

Open GarySiu opened 5 years ago

GarySiu commented 5 years ago

Cross-posting an issue from the docs repo: https://github.com/tachyons-css/tachyons-css.github.io/issues/193

It seems like somewhere along the line the yellows in tachyons were mixed up. This is reflected both in the CSS and in the docs: http://tachyons.io/docs/themes/skins/

FFFF00 should be yellow but has no name/is missing from Tachyons!

FFD700 should be gold (in line with the CSS keyword) but has been assigned yellow

FFB700 is some mystery orange variant but assigned gold

FF6300 is some mystery orange red variant but assigned orange

On the docs page this visually breaks the layout as yellow is unnamed.

orionrush commented 4 years ago

from _variables.scss in tachyons-sass

$orange: #ff6300 !default; "mystery orange red variant" $gold: #ffb700 !default; "some mystery orange variant" $yellow: #ffd700 !default; "should be gold (in line with the CSS keyword)" $light-yellow: #fbf1a9 !default; –– missing?

FFFF00 does not appear in _variables.scss

GarySiu commented 4 years ago

Yes. But it's used multiple times in the docs and breaking the layout there which is why I'm reporting it:

Screenshot of the missing text Second screenshot showing gap in layout

andrewhainen commented 3 years ago

The #FFFF00 being unlabeled has been confusing me as well