taciano-perez / getlamp-game

A simple text adventure implemented in multiple programming languages.
MIT License
6 stars 2 forks source link

PunyInform source formatting #8

Open fredrikr opened 1 week ago

fredrikr commented 1 week ago

Glad to find this project. I submitted a PR for fixing problems in the PunyInform version.

The source for the PunyInform version has some pretty bad formatting. I'd be happy to fix it if you want.

I would also suggest to change the library structure, since neither Inform 6 or PunyInform is really related to Inform 7 (except in a very technical way, which doesn't matter to regular users - Inform 7 code is typically compiled to Inform 6 code, which is then compiled to Glulx code, but no one looks at the Inform 6 code.

Also, I find that you don't actually have Inform 7 source. I think someone who knows Inform 7 would produce this for you in half an hour. This is quite interesting to include, as the language is so very different.

So for the directory structure I suggest either: ``´

fredrikr commented 1 week ago

Sorry, you do have an Inform 7 version! I mistook it for an ini file [:)]

taciano-perez commented 1 week ago

Hi @fredrikr, thanks for your contributions. The Inform and Adventuron versions were made by @nateProjects. I'm happy to merge the PRs, but I can't meaningfully review them. Maybe a good idea to add @nateProjects as reviewer for future PRs?

fredrikr commented 1 week ago

Sounds good!