Review/fix design for MigrationTaskSupport.name property

[scottfromsf]

The MigrationTask interface defines a getName method. MigrationTaskSupport provides a default implementation that includes a corresponding setName method. The problem is that there's nothing to indicate to MigrationTaskSupport subclasses that getName should return something. If getName returns null then the patch is ignored with a message in the log.

• is getName utilized for anything useful? If not, why is it required in ClassMigrationTaskSource?
• what can be done to encourage MigrationTaskSupport subclasses to implement getName?

[hemri]

It shouldn't be required. MigrationTask.getName() is used for logging purposes and is not related to the execution. For SQL and XML-based patches, the name is set as the name of the file that contains the patch. For Java-based patches it is required. MigrationTaskSupport would provided a default value for getName(), maybe the full qualified name of the Java class.

And the constraint in ClassMigrationTaskSource should be removed.