Closed tacitvenom closed 3 years ago
1) Reason for CI build failure found #24 - genome file was updated after the test was added - this wasn't picked up because the test was skipped all along. The correct value has been updated in the main branch with commit https://github.com/tacitvenom/genomics_algo/commit/e1fcb5b059bdfe97c8878d37dd33c415cd2bfee1
2) Another artificial long text test added test_find_pattern_clumps_long
for quick performance calculation and prototyping: Turns out this implementation takes ~35 seconds as opposed to ~25 seconds in the main branch with the naive implementation.
Closing this PR since the changes don't optimize the runtime really.
Sourcery Code Quality Report
❌ Merging this PR will decrease code quality in the affected files by 5.02%.
Here are some functions in these files that still need a tune-up:
Legend and Explanation
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.