search

taconaut / pms-mlx

The goal of this extension is to let the PS3 Media Server do the serving and transcoding jobs as well as it always did and to additionally offer a way to configure what files show up in which folder.
http://www.ps3mediaserver.org/forum/viewtopic.php?f=14&t=9775
GNU General Public License v2.0
6 stars 3 forks source link

improved wait/notify handling #46

Closed leonard84 closed 12 years ago

leonard84 commented 12 years ago

See http://stackoverflow.com/a/3186336 for an explanation on why to use notifAll over notify and why the condition for wait should be inside a loop

buildhive commented 12 years ago

Philippe » pms-mlx #26 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 12 years ago

Philippe » pms-mlx #27 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 12 years ago

Philippe » pms-mlx #28 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 12 years ago

Philippe » pms-mlx #29 FAILURE Looks like there's a problem with this pull request (what's this?)

taconaut commented 12 years ago

Cheers, I'll check your pull requests soon, but would like to finish the new project structure (including plugins first). Btw, the Cloudbees messages come from a Jenkins server I've put up on cloudbees but haven't finished configuring it; the errors have nothing to do with the pull request.

buildhive commented 12 years ago

Philippe » pms-mlx #39 FAILURE Looks like there's a problem with this pull request (what's this?)

taconaut commented 12 years ago

Haven't taken the time to check what's wrong, but cloudbees should be happy with your pull request now. For the jenkins build it executes this maven command:

com.savage7.maven.plugins:maven-external-dependency-plugin:resolve-external com.savage7.maven.plugins:maven-external-dependency-plugin:install-external package site

Build #38 on the trunk worked correctly, #39 which contains the changes from this pull request doesn't.

Builds can be accessed here: https://buildhive.cloudbees.com/view/My%20Repositories/job/taconaut/job/pms-mlx/

taconaut commented 12 years ago

Closing this pull request because it has been manually merged into the branch struct_leonard84

leonard84 commented 12 years ago

Sorry I had not time before to review it.

As for my comments I annotated the pull request https://github.com/taconaut/pms-mlx/pull/49/files

Am 07.07.2012 09:43, schrieb Philippe:

Closing this pull request because it has been manually merged into the branch struct_leonard84

Reply to this email directly or view it on GitHub: https://github.com/taconaut/pms-mlx/pull/46#issuecomment-6821320