search

taconaut / pms-mlx

The goal of this extension is to let the PS3 Media Server do the serving and transcoding jobs as well as it always did and to additionally offer a way to configure what files show up in which folder.
http://www.ps3mediaserver.org/forum/viewtopic.php?f=14&t=9775
GNU General Public License v2.0
6 stars 3 forks source link

Consistently package required libs in plugins #54

Closed taconaut closed 11 years ago

taconaut commented 12 years ago

The tmdb and imdb plugins require libraries to be packaged in the jar. When doing a 'mvn clean package' sometimes they are included, sometimes not. Why??

Raptor399 commented 12 years ago

If you set a dependency for that library, it should always be packaged (unless you set the scope of the dependency to "provided" or something).

I tried a couple of these in a row:

mvn clean package; unzip -t target/pms-imdb-movie-import-plugin-3.0-SNAPSHOT.jar

Always the "org/json/*" classes are in the package, as I would expect.

Or did you mean a different library?

taconaut commented 12 years ago

That's the one. For the tmdb plugins it would be jtmdb. I think this only happened on windows. If this happens, it's quickly visible because the configure button of the tmdb import plugin isn't rendered correctly because there is a ClassNotFoundException when calling getGlobalConfigurationPanel(). Can't tell where the problem lies, but it happens quite frequently.