search

tacoss / grunt-nightwatch

Run your Nightwatch.js tests with Grunt
50 stars 22 forks source link

Overrides nightwatch.json globals_path even if not set #29

Closed lgo closed 8 years ago

lgo commented 10 years ago

While the globals_path is not set in the nightwatch Gruntfile options, it still overrides any globals_path set by the nightwatch.json and makes the browser.globals object an empy object if not supplied.

Note, it seems to override browser.globals with the nightwatch.json globals variable, and if undefined it overrides it with an empty object - removing the contents of global_path.

pateketrueke commented 9 years ago

Hi again, I've published 0.4.0 to npm.

Can you test for that issue again?

YoungElPaso commented 8 years ago

I'm pretty sure I still experience this issue. I'm on 0.5.2. It seems no matter what I put in grunt.initConfig like: nightwatch: { options: { globals: {'foo':'bar'} } } It all gets stripped out by whatever is in nightwatch.json

pateketrueke commented 8 years ago

Interesting, I'll work on that asap.

Thanks for your feedback!

YoungElPaso commented 8 years ago

Sorry my bad. I think I just didn't nest the options properly to match what I had in my nightwatch.json file. I debugged your code pretty well and it works :)

pateketrueke commented 8 years ago

Holy moly! :beers: