tacoss / testcafe-blink-diff

Visual regression for Testcafé

65 stars 15 forks source link

fix: tests to care windows/others display resolution diff #73

Closed tomoh1r closed 3 months ago

tomoh1r commented 3 months ago

Description

Hi, I couldn't pass #72, so I change some tests, please check it

Substantial commit ids are below:

964b02a0aae2cad868ad81c65b961fdc2df736f8
86fe883a1e712994cc8c2e1247194b6c0bb49f30

Type of change:

Improvement (non-breaking change which fixes an issue)

How Has This Been Tested?:

[x] unittest

> & npm i
> & npx sirv e2e/public --port 3000
> & si -Path Env:\BASE_URL -Value "http://localhost:3000"
> & si -Path Env:\WINDOW_DPI -Value 1
> & npx testcafe edge:headless e2e/cases -s path=e2e/screens

[x] ok on my repository with add change node_modules package

Test Configuration:

OS: Windows11 23H2 22631.4112
nodejs: v20.17.0
npm: 10.8.3
Packages:
- testcafe@2.6.2

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

tomoh1r commented 3 months ago

Or, we could use lte then check betweenness values

tomoh1r commented 3 months ago

Add some betweenness tests in #74, thx!