fix: load address opt (#370)

tact-lang / tact

Tact compiler main repository

https://tact-lang.org

MIT License

267 stars 53 forks source link

fix: load address opt (#370) #373

Closed 0kenx closed 1 week ago

0kenx commented 2 weeks ago

Closes #370

[x] I have updated CHANGELOG.md
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I did not do unrelated and/or undiscussed refactorings

anton-trunov commented 2 weeks ago

Thanks a bunch for helping by contributing a fix! Really appreciate it. Could you please resolve the merge conflicts? Looks like your PR is based on an outdated version of the main branch

0kenx commented 2 weeks ago

Merged main

anton-trunov commented 2 weeks ago

Hey @0kenx, your contribution qualifies for the Tact contributor SBT, would you mind sharing your TON wallet?

anton-trunov commented 2 weeks ago

@0kenx CI is failing. You need to update some of the test snapshots, I tried pushing a fix to your branch but I don't have access. So I pushed it to the Tact repo: https://github.com/tact-lang/tact/commit/ae6f1df14a39f552437e9a56a41905bedad2e37a.

To do it on your side, you can use the following commands:

yarn gen && yarn build && yarn test -u

0kenx commented 1 week ago

CI fails for some snapshot tests, which I believe are expecting some particular FunC code to be generated, and since my code changed FunC code generation, those tests fail.

0kenx commented 1 week ago

It's now merged and all tests and lints pass on local.

0kenx commented 1 week ago

Hey @0kenx, your contribution qualifies for the Tact contributor SBT, would you mind sharing your TON wallet?

UQCbfeyLatuHjLHkuToQEoF37M9TU-RvQk-XSr9eu75vWteC

anton-trunov commented 1 week ago

Thanks a lot! SBT sent