fix: verify address for non-zero workchains

0kenx commented 1 week ago

Closes #369

[x] I have updated CHANGELOG.md
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I did not do unrelated and/or undiscussed refactorings

anton-trunov commented 1 week ago

Looks like there are some merge conflicts now

0kenx commented 1 week ago

-------------------------------------------
Issues found:
./CHANGELOG.md:21:65 - Unknown word (workchains)
./examples/__snapshots__/wallet.spec.ts.snap:20:38 - Unknown word (Tfre)
./examples/__snapshots__/wallet.spec.ts.snap:20:48 - Unknown word (Eikcyp)
./examples/__snapshots__/wallet.spec.ts.snap:20:58 - Unknown word (umrg)
./examples/__snapshots__/wallet.spec.ts.snap:48:38 - Unknown word (Tfre)
./examples/__snapshots__/wallet.spec.ts.snap:48:48 - Unknown word (Eikcyp)
./examples/__snapshots__/wallet.spec.ts.snap:48:58 - Unknown word (umrg)
./examples/__snapshots__/wallet.spec.ts.snap:65:42 - Unknown word (Tfre)
./examples/__snapshots__/wallet.spec.ts.snap:65:52 - Unknown word (Eikcyp)
./examples/__snapshots__/wallet.spec.ts.snap:65:62 - Unknown word (umrg)
./examples/__snapshots__/wallet.spec.ts.snap:95:38 - Unknown word (Tfre)
./examples/__snapshots__/wallet.spec.ts.snap:95:48 - Unknown word (Eikcyp)
./examples/__snapshots__/wallet.spec.ts.snap:95:58 - Unknown word (umrg)
./examples/__snapshots__/wallet.spec.ts.snap:126:38 - Unknown word (Tfre)
./examples/__snapshots__/wallet.spec.ts.snap:126:48 - Unknown word (Eikcyp)
./examples/__snapshots__/wallet.spec.ts.snap:126:58 - Unknown word (umrg)
./src/test/__snapshots__/feature-send.spec.ts.snap:21:33 - Unknown word (Ybxdypbqpxk)
./src/test/__snapshots__/feature-send.spec.ts.snap:21:55 - Unknown word (XBBPHS)
./src/test/__snapshots__/feature-send.spec.ts.snap:39:35 - Unknown word (Ybxdypbqpxk)
./src/test/__snapshots__/feature-send.spec.ts.snap:39:57 - Unknown word (XBBPHS)
./src/test/__snapshots__/feature-send.spec.ts.snap:70:33 - Unknown word (Ybxdypbqpxk)
./src/test/__snapshots__/feature-send.spec.ts.snap:70:55 - Unknown word (XBBPHS)
./src/test/__snapshots__/feature-send.spec.ts.snap:115:33 - Unknown word (Ybxdypbqpxk)
./src/test/__snapshots__/feature-send.spec.ts.snap:115:55 - Unknown word (XBBPHS)
./src/test/__snapshots__/feature-send.spec.ts.snap:133:37 - Unknown word (Ybxdypbqpxk)
./src/test/__snapshots__/feature-send.spec.ts.snap:133:59 - Unknown word (XBBPHS)
CSpell: Files checked: 443, Issues found: 26 in 3 files.

anton-trunov commented 1 week ago

I would add to the list of ignored files:

src/test/__snapshots__/feature-send.spec.ts.snap
examples/__snapshots__/wallet.spec.ts.snap

and workchains to the vocabulary: https://github.com/tact-lang/tact/blob/main/cspell.json#L57

0kenx commented 1 week ago

tact-template also has a snapshot test...

Gusarich commented 1 week ago

Forbidding other workchains is OK and it’s done in many common smart contracts.

However, we can introduce another configuration parameter for it, similar to the one that allows masterchain messages.

tact-lang / tact

fix: verify address for non-zero workchains #390