feat: optional trailing semicolons for struct/message field declarations

tact-lang / tact

Tact compiler main repository

https://tact-lang.org

MIT License

267 stars 53 forks source link

Closed anton-trunov closed 1 week ago

anton-trunov commented 1 week ago

Closes #393

[x] I have updated CHANGELOG.md
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I did not do unrelated and/or undiscussed refactorings

Gusarich commented 1 week ago

Agree with @novusnota

anton-trunov commented 1 week ago

What's the motivation behind the separate StructFields and not an inline ListOf<StructField, ";"> ";"?

To reduce duplication

anton-trunov commented 1 week ago

We can actually do the same for the other parts too. But in separate PRs

anton-trunov commented 1 week ago

I'm going to merge this and postpone some grammar refactoring to a later PR, this is tracked in #397