Cover message parsing via `.fromCell` and `.fromSlice` with tests

tact-lang / tact

Tact compiler main repository

https://tact-lang.org

MIT License

280 stars 56 forks source link

Closed Gusarich closed 1 week ago

Gusarich commented 1 week ago

Closes #453

[x] I have updated CHANGELOG.md
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I have run the linter, formatter and spellchecker
[x] I did not do unrelated and/or undiscussed refactorings

anton-trunov commented 1 week ago

Sorry, there are merge conflicts from #445 now

Gusarich commented 1 week ago

@anton-trunov done

anton-trunov commented 1 week ago

Could you please add more types to tests, like String, Bool and, say, StringBuilder (that one is rarely used as a Struct field, but just in case)?

Let's open a new issue on this, maybe with even a broader scope? If there are any bugs in this, we'll release v1.4.1 :)