fix: name clashes with FunC keywords for struct constructor parameters

tact-lang / tact

Tact compiler main repository

https://tact-lang.org

MIT License

280 stars 56 forks source link

fix: name clashes with FunC keywords for struct constructor parameters #467

Closed anton-trunov closed 5 days ago

anton-trunov commented 6 days ago

Closes #466

[x] I have updated CHANGELOG.md
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I have run the linter, formatter and spellchecker
[x] I did not do unrelated and/or undiscussed refactorings

novusnota commented 5 days ago

Cool, but seems like this ties us to FunC even more. Maintenance of the keyword list may bring occasional bugs in the future. I wonder if we could use different names, like prefixing things with underscores or even UUID's of sort?

anton-trunov commented 5 days ago

Cool, but seems like this ties us to FunC even more.

No, it does not, it does quite the opposite. The test shows you can use all current FunC keywords as your struct field identifiers. And it's highly unlikely FunC will have keywords starting with $.