Remove checking page boundaries when MemH is used as described here
Pass 0 as the third argument to sendREADRequest() and sendWRITERequest() since it isn't used
Remove the deprecated ReadMem() and WriteMem() functions -- they have been deprecated for long enough to remove them as clutter
Instead of having two WriteMem() functions, one with and one without a RevFLag flag last argument, make the flag argument have a default value of RevFlag::F_NONE which is the only difference between the two WriteMem() functions
Make ReadMem() similarly have an optional flag at the end -- previously it was mandatory for ReadMem()
Add a AdjPageAddr() function which consolidates page-crossing handling in one function:
It returns a { remainder, physAddr, adjPhysAddr } tuple
The remainder is the remainder in the first page; the physAddr is the address in the first page; the adjPhysAddr is the address in the second page
It ensures that the Len parameter is <= pageSize because otherwise three or more pages would be needed
Moves all of the RevMem address variables into the if( ctrl ) { ... } else { clause since they aren't needed by MemH
In this PR:
0
as the third argument tosendREADRequest()
andsendWRITERequest()
since it isn't usedReadMem()
andWriteMem()
functions -- they have been deprecated for long enough to remove them as clutterWriteMem()
functions, one with and one without aRevFLag flag
last argument, make the flag argument have a default value ofRevFlag::F_NONE
which is the only difference between the twoWriteMem()
functionsReadMem()
similarly have an optional flag at the end -- previously it was mandatory forReadMem()
AdjPageAddr()
function which consolidates page-crossing handling in one function:{ remainder, physAddr, adjPhysAddr }
tupleremainder
is the remainder in the first page; thephysAddr
is the address in the first page; theadjPhysAddr
is the address in the second pageLen
parameter is<= pageSize
because otherwise three or more pages would be neededRevMem
address variables into theif( ctrl ) { ... } else {
clause since they aren't needed by MemHCc: @Artlands