search

tactikauan / thcrap-steam-proton-wrapper

A wrapper script for launching the official Touhou games on Steam with patches through Proton on GNU/Linux.
The Unlicense
38 stars 6 forks source link

Fix thcrap_loader hanging after quitting game #5

Closed Maxmani closed 1 year ago

Maxmani commented 1 year ago

I noticed that for me and some others that thcrap_loader.exe hangs after the game is quit, preventing Steam from detecting that the game is closed. So, I updated the script to detect when the actual Touhou executable closes and run a command to kill the remaining thcrap process.

This is actually my first time writing (let alone modifying to this extend) a bash script, so it might be a little rough, not sure. I've tested it and it seems to run just fine.

I'll leave this PR as a draft for now as I test it some more.

Maxmani commented 1 year ago

Haven't tried setting a nondefault language but vpatch works. :+1:

tactikauan commented 1 year ago

It seems like this problem was introduced with the latest thcrap release. I haven't played in a while so I didn't notice it before.

Your patch looks solid from what I have tested, just gonna leave a suggestion on a line I think could be improved.

Thanks!

redirectto commented 1 year ago

After reading this, I decided to update my fork which goal is to add thprac (the practice tool) with the -p flag. I used the Maxmani script as the base so thcrap will be killed after closing the game https://github.com/redirectto/thprac-steam-proton-wrapper Take a look, maybe you want to add it to the master branch.

tactikauan commented 1 year ago

@redirectto Interesting. I'll have a look once I find some free time.

tactikauan commented 1 year ago

Sorry, I accidentally left my review on a pending state for a week so only I could see it lol.