Tracking Issue: Signal Bugs and Improvements

[tillprochaska]

This is a follow-up issue, collecting various smaller improvements and issues with the Signal integration.

Edit 13.06.22 (Theresa): As we've dealt with various smaller issues and/or bugs with the Signal integration while deploying to more instances with heavier usage of Signal, I am reactivating this issue to track and categorise the known issues:

Bugs

• [ ] Sentry Issue 100EYES-1S Sometimes, we receive a nil data_message for a plain text message.

• [ ] Long Signal Messages are getting cut off See #1337: "Long Signal messages are cut-off after ~2000 bytes. The full, non-truncated text of the message is attached to the message in a text file."

• [ ] Sometimes we receive a 400 Bad Request for some but not all contributors when sending a message See #1386. See Sentry Issue 100EYES-1N.

• [ ] Needs research: Possibly loosing message which are processed at the same time as a message which we cannot process. While testing Sentry Issue 100EYES-3G on staging I remember that I sent three messages which were polled together from which two had an attachment and should have been able to be processed and one didn't and caused the exception. However, none of the messages appeared in 100eyes. This should actually not be the case as we rescue errors produced during consuming Signal messages. It might be worth finding out if this is reproducible.

Not supported features that should be supported

• [ ] Add mpeg to allowed audio types
• [ ] Check for further needed / possible support for image / audio types We are currently pretty restrictive on types of image and audio which we accept. This can lead to attachments (which we could accept without any code changes) being rejected to a high decrease of user friendliness. Being more accepting if we can store and display the attachment without problems in the browser could help to avoid further not supported attachment bugs. E.g. like in the case of sending voice messages from desktop apps which use a different audio format than the phones we tested Signal on.

Enhancements

• [ ] Support videos Allows e.g. also for 360 degree images.

• [ ] Do not discard initial "Hello" messages by contributors. In order to complete the Signal onboarding process, contributors have to send us an initial message. Currently, we discard this message. Those messages might contain important information or questions by contributors and as such, we should keep and handle them in the same way we handle any other message.

• [x] Handle emoji reactions

• [x] Format phone number in an easier-to-read way We should add spaces and (probably) omit the leading country code.

  

• [ ] Format phone number in usual easier-to-read way Follow-up to easier-to-read way enhancement. Now we display phone numbers with phony_formatted, aka e.g. signal_phone_number.phony_formatted. The preset leads to numbers being displayed as e.g.: 0176 9999 9999 instead of the more common 0176 999 999 99.

  • [ ] Enable failed message sending retries from Admin dashboard We stored failed message sending jobs with the goal of making it possible to retry them on a later date. It could be convenient to be able to retry them directly from the Admin dashboard.

[FrauCsu]

Can we prioritize "handle emoji reactions" @tillprochaska ?