tactivos / grunt-cdn

79 stars 53 forks source link

<meta name="viewport"> is cdnified #56

Closed daniel-lang closed 9 years ago

daniel-lang commented 10 years ago

this tasks turns <meta name="viewport" content="width=device-width, height=device-height, initial-scale=1, maximum-scale=1, user-scalable=no" /> into <meta name="viewport" content="cdn.com/width=device-width,%20height=device-height,%20initial-scale=1,%20maximum-scale=1,%20user-scalable=no"

nicolashenry commented 10 years ago

I have the same issue with the version '0.5.6' on npm (https://www.npmjs.org/package/grunt-cdn) which does not exist on this repository.

johnnyhalife commented 10 years ago

Guys,

code for 0.5.6 is up on the repo, if you find a workaround please send a pull-request. The ultimate goal of that was to CDNify the favicon and all that.

thanks, ~johnny

On Mon, Sep 1, 2014 at 8:31 AM, Nicolas HENRY notifications@github.com wrote:

I have the same issue with the version '0.5.6' on npm ( https://www.npmjs.org/package/grunt-cdn) which does not exist on this repository.

— Reply to this email directly or view it on GitHub https://github.com/tactivos/grunt-cdn/issues/56#issuecomment-54049149.

nicolashenry commented 10 years ago

As far as I know, a favicon is defined by a link tag (http://www.w3.org/2005/10/howto-favicon). What is the use case supposed to be covered?

ErikEvenson commented 10 years ago

+1

HellPat commented 10 years ago
Changing /width=device-width -> http://cdn.dev/width=device-width
Changing /text/html;%20charset=UTF-8 -> http://cdn.dev/text/html;%20charset=UTF-8
Changing /width=device-width -> http://cdn.dev/width=device-width
Changing /text/html;%20charset=UTF-8 -> http://cdn.dev/text/html;%20charset=UTF-8
Changing /width=device-width -> http://cdn.dev/width=device-width
Changing /text/html;%20charset=UTF-8 -> http://cdn.dev/text/html;%20charset=UTF-8
Changing /width=device-width -> http://cdn.dev/width=device-width
Changing /text/html;%20charset=UTF-8 -> http://cdn.dev/text/html;%20charset=UTF-8
Changing /width=device-width -> http://cdn.dev/width=device-width
Changing /text/html;%20charset=UTF-8 -> http://cdn.dev/text/html;%20charset=UTF-8

I had some other occurences.

statico commented 9 years ago

+1

daniel-lang commented 9 years ago

thank you for fixing this