search

tactivos / grunt-htmlrefs

Replaces (or removes) references to non-optimized scripts or stylesheets on HTML files
27 stars 14 forks source link

grunt isn't a dependency #1

Closed dcardosods closed 11 years ago

dcardosods commented 11 years ago

Insert grunt into devDependencies in package.json

johnnyhalife commented 11 years ago

Hi @dcardosods, we have grunt as a dependency not as a dev-dependency.

https://github.com/tactivos/grunt-htmlrefs/blob/master/package.json#L21

Do you need anything different? Why did you raised this concern?

dcardosods commented 11 years ago

Isn't necessary grunt as a dependency, grunt should be in devDependencies. How it works now, when make npm install grunt-htmlrefs, grunt going to install too. In devDependencies grunt is installed only if clone the project to contribute. See https://github.com/gruntjs/grunt/pull/263, and the grunt-contrib plugins https://github.com/gruntjs/grunt-contrib.

PS sorry for my bad english

johnnyhalife commented 11 years ago

got it, thanks for the feedback @dcardosods