search

tadeuzagallo / GithubPulse

OS X StatusBar app to help you remember to contribute every day on Github
http://tadeuzagallo.com/GithubPulse
MIT License
542 stars 20 forks source link

Following list #32

Closed johnknaack closed 9 years ago

tadeuzagallo commented 9 years ago

Hey, I hop you don't mind, but I made some minor changes to your code.

User's contributions now are fetched in parallel and cached for 15 minutes. I also sorted the users by the streak size and number of commits today. I last I changed the pieces of code where the state was mutate directly, which should be avoided.

If you mind having a look the code is on the johnknaack-following-list branch

johnknaack commented 9 years ago

Looks great to me. I've been working in isolation at a private company for the last few years. It's actually nice to get some feedback on what I can improve on. I look forward to making make some of these adjustments on some of our production apps.

tadeuzagallo commented 9 years ago

Yeah, I've been there, to me that's certainly the best part of Github! If you want an opinion on any code feel free to ping me... :)