tadfisher / pass-otp

A pass extension for managing one-time-password (OTP) tokens
GNU General Public License v3.0
1.26k stars 86 forks source link

Fix HOTP counter increases #172

Open jorti opened 1 year ago

jorti commented 1 year ago

When substituting the counter in a HOTP uri, the replacement string needs to be quoted because it contains a &. Quoting it will avoid & to be replaced with the matching portion of the pattern.

See: https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html

Fixes #171

fstecker commented 8 months ago

@tadfisher is there any chance you could merge this soon? As long as this isn't fixed, pass-otp does not work with bash 5.2 (at least not for HOTP).