search

tadfisher / pass-otp

A pass extension for managing one-time-password (OTP) tokens
GNU General Public License v3.0
1.28k stars 85 forks source link

Pass bash completion does not work with the otp command #28

Open ghost opened 7 years ago

ghost commented 7 years ago

Hi,

Pass bash completion does not work when using the otp command in Ubuntu (with other non pass-otp commands it does work).

I am using pass v1.7 and pass-otp v1.0.0.

Thanks

tadfisher commented 7 years ago

I wouldn't expect it to work unless the completion function was extension-aware, and it's not.

I'd report this as a general issue to the pass mailing list, as there's nothing this project can do to enable completion without support from upstream.

bexelbie commented 6 years ago

Could we modify the installation procedure to edit the bash completion information provided by upstream? It seems a sed of that file could get us the completion, unless we can get upstream to support generalized plugin completion somehow.

This would require us to do some level of integration testing against new versions of pass though in case this file changed and broke the sed.

tadfisher commented 6 years ago

No, I'm not going to modify files packaged by another application.

I'll work on generalizing completion in pass itself.

innir commented 6 years ago

Just linking the corresponding issues of other extensions: https://github.com/roddhjav/pass-update/issues/9 and https://github.com/palortoff/pass-extension-tail/issues/4

GFdevelop commented 5 years ago

I'm vote for this iussue...pass-extension-tail have found a solution for this, see here https://github.com/palortoff/pass-extension-tail/blob/master/completion/pass-tail.bash.completion

micah commented 5 years ago

Hey @tadfisher !

I'm wondering if you made any progress in generalizing completion in pass as you mentioned last year in your comment?

The thing that drives me nuts with pass otp is the lack of tab completion!

bexelbie commented 5 years ago

Looks like the bash completion added in 1.7.3 needs to be updated as the extension method isn't working. I see a patch proposed from Feb 2 on the mailing list but no action, so I bumpted it.

NilsIrl commented 4 years ago

This now seems to be possible:

NilsIrl commented 4 years ago

@tadfisher You haven't been active in a long time (in regards to pass-otp), what should we do going forward?

bexelbie commented 4 years ago

Perhaps we can add more committers @tadfisher ?

heavyimage commented 1 year ago

This is still broken I think? I'll source the otp completion manually for now but would be cool if this just worked!

ghost commented 1 year ago

Is this task dead?

The bash completion is still missing in pass-otp...

xundeenergie commented 1 year ago

I've just created a pull-request for pass itself https://github.com/zx2c4/password-store/pull/5