search

tadfisher / pass-otp

A pass extension for managing one-time-password (OTP) tokens
GNU General Public License v3.0
1.28k stars 85 forks source link

Check that test requirements are installed before running additional tests #61

Closed LucidOne closed 6 years ago

LucidOne commented 6 years ago

This is for everyone running make test outside of Travis CI that forgets to install test requirements. It might make more sense to name it Requirements.t to fix the sort order, but I think it comes down to aesthetics.

roddhjav commented 6 years ago

Hi, In my opinion, it is not the correct way for testing this. Like this you add a test to pass-otp. However, you only want to check test dependencies. You put this checks in the setup.sh file.

See for example: https://github.com/roddhjav/pass-tomb/blob/master/tests/setup#L34

LucidOne commented 6 years ago

See #63