tadwohlrapp / soldby

SoldBy – Reveal Sellers on Amazon: See their name, country of origin and rating when browsing Amazon.
MIT License
53 stars 5 forks source link

Disable SoldBy in cart and checkout process #16

Open tadwohlrapp opened 2 years ago

tadwohlrapp commented 2 years ago

What's the problem this feature will solve?

The script parses items in the shopping cart as well. This is unnecessary and might be distracting. Also it tries and fails to add the settings link to the footer, on the checkout page.

Describe the solution you'd like

Exclude sidebar cart als well as cart and checkout pages, and maybe all other account related pages, too.

Additional context

Bildschirmfoto 2022-06-22 um 14 04 48 Bildschirmfoto 2022-06-22 um 14 04 39 Bildschirmfoto 2022-06-22 um 14 09 24
SocietasEvanescentes commented 2 years ago

I actually personally don't mind this. Especially if I didn't notice a product was Chinese before, or if I did, it gives me a second chance to evaluate if I really want the product or not. If you do choose to change this feature, if possible, I'd love to see a feature in the settings to configure whether to show it in checkout/sidebar :)

LittleFreak commented 2 years ago

its an security issue by any means. Like why would the script have access to an sub-page, where there shouldn't be anything to accomplish. No Userscript should even have the chance to spy on my purchase details nor passwords by default. I propose to exclude them in the script, in the meantime, I'll set them as user exclude.

User Exclude:

https://smile.amazon.de/ap/signin/*
https://smile.amazon.de/ap/signin?*
https://smile.amazon.de/gp/buy/*