search

tadzik / rakudobrew

Perl 6 installation manager
MIT License
185 stars 42 forks source link

Travis broken #134

Closed masak closed 5 years ago

masak commented 5 years ago

I think #133 broke perl6 Travis.

I'm not at a computer right now, so I can't debug it all that deeply. But see https://travis-ci.org/masak/007/builds/522665566 for a failing build that works locally.

masak commented 5 years ago

Ping @patzim and @niner who might have some insight into why the breakage.

masak commented 5 years ago

At a computer now. The error message is this:

$ rakudobrew build moar
The shell hook required to use rakudobrew in 'env' mode and use the 'shell' command seems not to be installed.
Run 'rakudobrew init' for installation instructions.

The if statement that triggers was added in #133: this one. I'm guessing it's get_brew_mode() eq 'env' that triggers true in this case.

Not sure it this point whether this is a bug in rakudobrew, or whether the Perl 6 support for Travis-CI just needs to be reconfigured. (In which case I should probably report it at the Travis discussion forum.)

masak commented 5 years ago

Scanning the IRC logs. rindolf just got informed this was due to network related problems. Can't say this matches my observation so far; to me, it seems to be due to the changes in #133.

masak commented 5 years ago

(I can't log onto IRC, by the way. That may well be because of the reported DNS/network problem.)

@tadzik has a solution here, but I'm not sure how to express that as concrete steps to make my Travis CI runs pass again. My config file just says language: perl6; it doesn't mention rakudobrew at all. I'm at a loss how to check out v1 of rakudobrew in my Travis runs.

patrickbkr commented 5 years ago

Looking into this right now.

patrickbkr commented 5 years ago

I created a travis-build PR: https://github.com/travis-ci/travis-build/pull/1693 I also pinged nine and tadzik to maybe revert rakudobrew. We'll see what happens first.

patrickbkr commented 5 years ago

rakudobrew is now completely reverted to before the big overhaul. Travis testing should work again now. The Travis PR above is hopefully merged in the coming days which should pin Travis to a specific rakudobrew version, helping stability. I'm hoping this works out and does not break in some other unforseen way...

patrickbkr commented 5 years ago

@masak Could you have another look if stuff actually works again?

masak commented 5 years ago

Yes, all green now on the original configuration. Thank you; closing.

JJ commented 5 years ago

This means that the master branch is broken? Should we all use v1 now?

patrickbkr commented 5 years ago

@JJ No, it's not broken. Just the way to install rakudobrew has changed in a minor detail which caused the automated travis build of perl6 to fail, as it tried to install the new rakudobrew in a way only working with an old rakudobrew. See here. That line suffices to get the old rakudobrew somehow working but not the new one. Rakudobrew is not documented to be used that way.

JJ commented 5 years ago

The thing is that I also use rakudobrew for my whole set of Alpine-based containers. I'll see what's best, to use v1 or to switch to the new installation procedure.