taers232c / GAM-Scripts3

Scripts for use with GAM - Python 3.6+
229 stars 49 forks source link

Scripts depending on team drive organizers #18

Closed ebarti closed 1 month ago

ebarti commented 1 month ago

Hey, thank you so much for all your excellent work with GAMAdv and these scripts.

Raising this issue I am having as we have team drives with multiple organizers, and thus scripts that perform user-based operations on the organizers row fail.

Specifically, this step listed here https://github.com/taers232c/GAM-Scripts3/blob/master/GetSharedExternallyTeamDriveACLs.py#L32 fails for teams with multiple organizers, but I think this could be extended to other scripts that make use of shared drive organizers.

taers232c commented 1 month ago

Eloi,

What does "fails" mean?

You should have made these changes to GetTeamDriveOrganizers.py; in particular, you want ONE_ORGANIZER = True

If you want to limit organizers to a specific list of domains, use the list below, e.g., DOMAIN_LIST = ['domain.com',] DOMAIN_LIST = ['domain1.com', 'domain2.com',]

DOMAIN_LIST = []

INCLUDE_TYPES = { 'user': True, # False - don't show user organizers, True - show user organizers
'group': False, # False - don't show group organizers, True - show group organizers
}

ONE_ORGANIZER = Truee # False - show all organizers, True - show one organizer
SHOW_NO_ORGANIZER_DRIVES = True # False - don't show drives with no organizers, True - show drives with no organizers

If you're using the output to just get file lists and won't be processing ACLs, fileOrganizers will work; otherwise you only want organizers,

INCLUDE_FILE_ORGANIZERS = False # False - do not include file organizers, True - include file organizers

Ross

Ross Scroggs @.***

On Jun 12, 2024, at 6:02 AM, Eloi Barti @.***> wrote:

Hey, thank you so much for all your excellent work with GAMAdv and these scripts.

Raising this issue I am having as we have team drives with multiple organizers, and thus scripts that perform user-based operations on the organizers row fail.

Specifically, this step listed here https://github.com/taers232c/GAM-Scripts3/blob/master/GetSharedExternallyTeamDriveACLs.py#L32 fails for teams with multiple organizers, but I think this could be extended to other scripts that make use of shared drive organizers.

— Reply to this email directly, view it on GitHub https://github.com/taers232c/GAM-Scripts3/issues/18, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL53BCN4ZS36WX7ABE3ZHBBGPAVCNFSM6AAAAABJGKIAJSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DQNZSGI3DQMQ. You are receiving this because you are subscribed to this thread.

ebarti commented 1 month ago

Hey @taers232c happy Friday.

I am following one of what I believe are pre-steps that need to happen before executing the script.

Step 5 is a direct GAM invocation, which fails as the csv input row for "organizers" contains multiple email addresses, and gam is unable to execute a call like gam user user1@domain.com user2@domain.com user3@domain.com print filelist select teamdriveid aTeamDriveID fields teamdriveid,id,name,permissions,mimetype

taers232c commented 1 month ago

Right, because when you ran GetTeamDriveOrganizers.py you didn't set:

ONE_ORGANIZER = True

Ross

On Fri, Jun 14, 2024 at 7:32 AM Eloi Barti @.***> wrote:

Hey @taers232c https://github.com/taers232c happy Friday.

I am following one of what I believe are pre-steps that need to happen before executing the script.

Step 5 is a direct GAM invocation, which fails as the csv input row for "organizers" contains multiple email addresses, and gam is unable to execute a call like gam user @. @. @.*** print filelist select teamdriveid aTeamDriveID fields teamdriveid,id,name,permissions,mimetype

— Reply to this email directly, view it on GitHub https://github.com/taers232c/GAM-Scripts3/issues/18#issuecomment-2168175526, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL6WIOGN32ENLSFXIWDZHL5JNAVCNFSM6AAAAABJGKIAJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGE3TKNJSGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Ross Scroggs @.***

taers232c commented 1 month ago

I am available for the next 15 minutes if you'd lke to Meet/Zoom.

Ross

ebarti commented 1 month ago

I am so sorry for wasting your time @taers232c 😓 Thank you! 🙏🏼