search

taf2 / curb

Ruby bindings for libcurl
Other
1.29k stars 229 forks source link

`test_connection_keepalive(TestCurbCurlMulti)` skipped with Curl 8+ #447

Open voxik opened 1 year ago

voxik commented 1 year ago

I know the Curl 8+ is out of support matrix. Nevertheless, Curl 8.4.0 is the version available in Fedora and everything seems to be fine except that test_connection_keepalive(TestCurbCurlMulti) is skipped. This seems to be due to this condition:

https://github.com/taf2/curb/blob/13144ec5d50ffea0460298cc5de8a0b33db78d22/tests/tc_curl_multi.rb#L16

Which does not account for major version.

voxik commented 1 year ago

The commit 06e81e66bc6876f1653e4428996440fcf2440bad introducing the condition above remove use Google, while the test case keeps referring to Google:

https://github.com/taf2/curb/blob/13144ec5d50ffea0460298cc5de8a0b33db78d22/tests/tc_curl_multi.rb#L25 https://github.com/taf2/curb/blob/13144ec5d50ffea0460298cc5de8a0b33db78d22/tests/tc_curl_multi.rb#L78-L79