taf2 / telephone

Automatically exported from code.google.com/p/telephone
Other
0 stars 0 forks source link

Autocomplete does not show number type and is not wide enough #85

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Start typing the name of a contact that is in your addressbook into the 
Telephone window
2. Notice that if a contact has multiple numbers, it is not possible to 
determine wich is home or 
work
3. Notice that the popup with the list of suggested numbers has a fixed width 
that cuts of parts 
of contacts with long names. Making the main window wider does not change the 
width of the 
suggestion box.

What is the expected output? What do you see instead?
A more detailed list of possible contacts/numbers that makes it possible to 
determine the 
difference between work, home and mobile numbers of the same person. Maybe even 
hierarchical:
Contact 1 Name
__work: +12 345 567 890
__home: +12 345 567 890
__mobile: +12 345 567 890
Contact 2 Name
__home: +12 345 567 890
__mobile: +12 345 567 890

What version of the product are you using? On what operating system?
0.12.1 (15), OSX 10.5.6

Original issue reported on code.google.com by stefan.f...@gmail.com on 27 Feb 2009 at 11:07

GoogleCodeExporter commented 8 years ago
I don't think the width problem will be solved in the near future, because the 
completion string implementation 
is based on the standard token field UI element. But I agree that it should be 
something with a nicer look.

The problem with the phone type will partially be solved in the next release 
(0.13) with the Address Book plug-
in. It will be possible to start dialling not only from the Telephone window, 
but from the Address Book card.

Anyway, thanks for the suggestions.

Original comment by eofs...@gmail.com on 27 Feb 2009 at 11:31

GoogleCodeExporter commented 8 years ago

Original comment by eofs...@gmail.com on 27 Feb 2009 at 11:32

GoogleCodeExporter commented 8 years ago

Original comment by eofs...@gmail.com on 6 Mar 2009 at 12:15

GoogleCodeExporter commented 8 years ago
Following is a small patch that at least shows the localizedPhoneLabel:

Index: AccountController.m
===================================================================
--- AccountController.m (revision 921)
+++ AccountController.m (working copy)
@@ -1535,11 +1535,12 @@
     // Add phone numbers. Display completion as Display Name <1234567>.
     for (i = 0; i < [phones count]; ++i) {
       NSString *phoneNumber = [phones valueAtIndex:i];
+      NSString *localizedPhoneLabel = [AB ak_localizedLabel:[phones 
labelAtIndex:i]];
       NSString *completionString = nil;

       if (contactName != nil) {
-        completionString = [NSString stringWithFormat:@"%@ <%@>",
-                            contactName, phoneNumber];
+        completionString = [NSString stringWithFormat:@"%@ - %@ <%@>",
+                            contactName, localizedPhoneLabel, phoneNumber];
       } else {
         completionString = phoneNumber;
       }

Original comment by imageadd...@googlemail.com on 16 Sep 2009 at 4:16

GoogleCodeExporter commented 8 years ago
Issue 241 has been merged into this issue.

Original comment by eofs...@gmail.com on 29 Oct 2009 at 6:55

GoogleCodeExporter commented 8 years ago
Issue 303 has been merged into this issue.

Original comment by eofs...@gmail.com on 30 Mar 2010 at 10:35

GoogleCodeExporter commented 8 years ago
Was there a plugin that can be used to get some of this functionality?  You 
mentioned a 0.13 release.

Thanks!

Original comment by dataf...@gmail.com on 6 Apr 2010 at 6:00

GoogleCodeExporter commented 8 years ago
Telephone installs Address Book plug-in, which allows you to initiate calls 
from the Address Book application.

Original comment by eofs...@gmail.com on 6 Apr 2010 at 7:28

GoogleCodeExporter commented 8 years ago
In both versions 1.0 and 1.01 this point is not solved.
Selecting a contact, nothing is displayed to make a difference between 
Mobile/Phone/Fax, ... I don't know if UI could enable to use the same icon as 
we have in the contact manager, but this would be a great improvement.

Original comment by Stipsy...@gmail.com on 30 Jan 2011 at 1:29