search

taffybar / gtk-sni-tray

A StatusNotifierHost widget written using the gtk+3 bindings for haskell provided by gi-gtk.
BSD 3-Clause "New" or "Revised" License
35 stars 2 forks source link

Support scroll method. #26

Closed kurnevsky closed 2 years ago

kurnevsky commented 2 years ago

Tested with pasystray - it changes volume on scroll.

colonelpanic8 commented 2 years ago

So basically it scrolls whatever your mouse has focus over? I'm not familiar with how gdk would process the scroll event.

kurnevsky commented 2 years ago

Cool! Don't we need something similar for "SecondaryActivate"

Yes, but scroll event seemed to me simpler to implement, so I started with it :)

So basically it scrolls whatever your mouse has focus over? I'm not familiar with how gdk would process the scroll event.

Yes.

colonelpanic8 commented 2 years ago

Yes, but scroll event seemed to me simpler to implement, so I started with it :)

Isn't it like the exact same thing pretty much? Just need to handle a different event, right?

kurnevsky commented 2 years ago

Isn't it like the exact same thing pretty much? Just need to handle a different event, right?

Yes, but we already handle button press event. So likely we will need to check event type in that handler. And I'm not sure how it's handled now - in some cases it creates menu passed as parameter and in other cases it calls IC.activate. So I wonder if it needs to be changed somehow. Are there cases when we might want to call IC.activate if there is a menu?