search

tafia / calamine

A pure Rust Excel/OpenDocument SpreadSheets file reader: rust on metal sheets
MIT License
1.67k stars 156 forks source link

Using NOM based parsing #218

Closed vivekvpandya closed 1 year ago

vivekvpandya commented 3 years ago

NOM https://docs.rs/nom/6.1.2/nom/ based parsing can increase speed significantly. I also assume that calamine uses streaming approach. Please correct me if that is wrong.

kkirsanov commented 3 years ago

Usually, everything is really easier and faster on parser combinators. :) But I'm not sure that there will be time and effort to transfer all the parsing to them.

tafia commented 3 years ago

I personnaly won't spend time on rewriting it but I am opened to reviewing pull requests and see if this is beneficial.

LovingMelody commented 3 years ago

Looked through the project to add this, I'm unsure if I sure if this is really something that would be beneficial to the project. cfb.rs & vba.rs seems to be already be a series of parsers.