tafia / calamine

A pure Rust Excel/OpenDocument SpreadSheets file reader: rust on metal sheets
MIT License
1.61k stars 155 forks source link

ODS: optimize handling table:number-columns-repeated attribute #310

Closed dimastbk closed 1 year ago

dimastbk commented 1 year ago

This PR improves the performance of parsing ODS file, which produced by some spreadsheets, like LibreOffice Calc or Google Sheet, which add table:number-columns-repeated with large value, about 16000. We can make pushing empty cell with table:number-columns-repeated attribute lazy. See also the same optimization for table:number-rows-repeated in #308.

The new test add test of handling merged cell (table:covered-table-cell) before empty cell.

tafia commented 1 year ago

there seem to be some conflict

tafia commented 1 year ago

Thanks for the PR. Do you mind chcking the conflict? Thanks

dimastbk commented 1 year ago

@tafia rebased.

tafia commented 1 year ago

Thanks