search

tafia / calamine

A pure Rust Excel/OpenDocument SpreadSheets file reader: rust on metal sheets
MIT License
1.69k stars 158 forks source link

Dependency bump and clippy #347

Closed jqnatividad closed 1 year ago

jqnatividad commented 1 year ago

bump dependencies and apply select clippy lint suggestions

jqnatividad commented 1 year ago

Hi @tafia , The PR is failing the Rust 1.60.0 test because the flate2 crate is deriving defaults on enums.

This feature has been stable since Rust 1.62. Do you need calamine to work on 1.60 for a particular reason?

Any chance we can bump the MSRV to 1.62.0, and while we're at it, maybe even bump the edition to 2021?

tafia commented 1 year ago

No particular strong reason. You can move it to 1.62.

tafia commented 1 year ago

I'm afraid there is now a conflict though due to older PR being merged. Could you fix it?

jqnatividad commented 1 year ago

Hi @tafia , I resolved the conflicts and bumped MSRV to 1.62.1 and edition to 2021.

I also went ahead and derived Default for DataType now that we're using 1.62.1.

tafia commented 1 year ago

Awesome thanks!