search

tafia / calamine

A pure Rust Excel/OpenDocument SpreadSheets file reader: rust on metal sheets
MIT License
1.6k stars 155 forks source link

Fixes #374 #375

Closed saks closed 6 months ago

saks commented 7 months ago

This PR fixed #374. The logic is inspired by the implementation of https://github.com/SheetJS/sheetjs/. Example file is copied from https://github.com/SheetJS/test_files.

I do realize that this change fixes an issue that can only occur when file was created using really old software but customers still upload such files, hence I truly believe it is a useful addition to this project.

Please let me know if there is anything that I can improve/fix.

saks commented 7 months ago

Thanks a lot! I have made a few comments, do you mind using an enum and specifying in comments where the logic for biff_version == 0 is coming from? I can't find it. Thanks!

Thanks for the review! PR updated. Please let me know if changes are making sense.