Rename `DataType` methods `as_f64` `as_i64` into `as_float` `as_int`

[lucatrv]

@tafia can this be merged or is anything else needed?

[tafia]

There are conflicts, sorry it is because of another PR I just merged.

[lucatrv]

@tafia, sorry I just had a second thought about this, maybe the reason for the current nonuniform naming is because:

• is_float means: check if the Data variant is Float.
• get_float means: if the Data variant is Float, get its content.
• as_f64 means: try to convert any Data variant into an f64 type.

In this case, maybe the current naming is correct. Please let me know your thought, then I will either close this PR or resolve its conflicts for merging. I am ready to create a new PR to add deserialize helping function which will work similarly to csv::invalid_option, but I am stuck due to this PR, so I hope you'll let me know soon. Thanks

[tafia]

Sorry for the late answer. Yes this was the idea but I too am unsure about the names. If you are unsure, then let's not do anything so it won't break too much code. I let it opened for now for other people to comment either way.

[lucatrv]

Sorry for the late answer. Yes this was the idea but I too am unsure about the names. If you are unsure, then let's not do anything so it won't break too much code. I let it opened for now for other people to comment either way.

Yes I agree. I created PR #406 to close issue #339 based on the current as_f64 and as_i64 methods.