search

tafia / calamine

A pure Rust Excel/OpenDocument SpreadSheets file reader: rust on metal sheets
MIT License
1.6k stars 155 forks source link

Replace `zip` with `zip_next` #423

Closed Pr0methean closed 2 months ago

Pr0methean commented 2 months ago

The zip crate hasn't been updated in almost a year, and has a number of bugs that can cause panics when trying to process an invalid zip file. This PR replaces it with zip_next, a fork I actively maintain.

tafia commented 2 months ago

Did you notice any performance impact?

Pr0methean commented 2 months ago

I haven't run the benchmarks, but I can assure you that a regression is highly unlikely.

Dirreke commented 2 months ago

As the update in zip_next come back to zip, maybe we can replace zip_next back with zip 1.0 @Pr0methean

Pr0methean commented 2 months ago

Smart move. I was invited to take over the zip name so that the upgrade path would be more visible.

Pr0methean commented 2 months ago

They already have; zip-next is now a wrapper around zip, published from the same repository as zip-next used to be published from.

On Tue, Apr 30, 2024, 00:36 Dirreck @.***> wrote:

As the update in zip_next come back to zip, maybe we can replace zip_next back with zip 1.0 @Pr0methean https://github.com/Pr0methean

— Reply to this email directly, view it on GitHub https://github.com/tafia/calamine/pull/423#issuecomment-2084599285, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF3NBLLLDVYNPSU6KTECVTY75CZVAVCNFSM6AAAAABGBAITBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUGU4TSMRYGU . You are receiving this because you were mentioned.Message ID: @.***>