Open dignifiedquire opened 1 year ago
Hi! Thanks for letting me know! I've just newly cloned the master branch and ran the run_test.sh
script; seemed to work though, even after multiple times.
git clone https://github.com/tafia/quick-protobuf.git
cd quick-protobuf/
./run_test.sh > runlog 2>&1 # log to runlog
You might notice that there's a bunch of files generated at the start of my output that I don't see in your output; namely
+ cd quick-protobuf/tests/rust_protobuf
+ ./generate.sh
v2/issue118-2.proto: ok
v2/issue118.proto: ok
v2/issue_170_a.proto: ok
v2/issue_170_b.proto: ok
// etc etc etc...
Do you think you could let me know the leadup to how you ran the tests?
The test works by:
pb-rs
to generate .rs
files inside quick-protobuf/tests/rust_protobuf/v2
and quick-protobuf/tests/rust_protobuf/v3
.rs
files.From the error messages, it looks like some files have not been generated, which potentially lines up with the difference in output. The code that generates them is ultimately in quick-protobuf/tests/rust_protobuf/generate.sh
.
Okay I think this might be because of OS issues. I was originally trying on macOS, running on my linux box, everything works out fine.
seems like CI would catch all such issues. Ideally the tests should run with a simple cargo test
-- that's what most Rust devs would expect. But in rare cases this is too hard to implement (e.g. if a database is required), in which case people have used just. I hope this repo can just use the cargo test
without any extra steps, but I haven't looked in depth yet
Trying to run tests with the
run_test.sh
I get quite a lot of failures: https://gist.github.com/dignifiedquire/c03ae16417f9f27fe4eabd1e5c823d7eRunning
cargo test -p quick-protobuf
also fails.Any guidance how to run them locally would be appreciated.