search

tag1consulting / goose

Load testing framework, inspired by Locust
https://tag1.com/goose
Apache License 2.0
807 stars 70 forks source link

Support nids higher than 255 (u32 vs u8) #491

Closed ElijahLynn closed 2 years ago

ElijahLynn commented 2 years ago

Ran into this error with nids in the thousands. 

error: literal out of range for `u8`                                                   
  --> examples/umami/common.rs:34:26                                                   
   |                                                                                   
34 |                     nid: 34054,                                                   
   |                          ^^^^^                                                    
   |                                                                                   
   = note: the literal `34054` does not fit into the type `u8` whose range is `0..=255`

Changed, https://github.com/tag1consulting/goose/blob/d5274ae75d33ab1df20c5d5e0dc995151738ab73/examples/umami/common.rs#L17-L18 from u8 to u32 and all is well now.

jeremyandrews commented 2 years ago

Thanks! A PR against Goose Eggs would be welcome as well: https://github.com/tag1consulting/goose-eggs/blob/main/examples/umami/common.rs#L16