tag1consulting / goose

Load testing framework, inspired by Locust
https://tag1.com/goose
Apache License 2.0
759 stars 69 forks source link

remove dependency on num_cpus #543

Closed jeremyandrews closed 1 year ago

jeremyandrews commented 1 year ago
bebehei commented 1 year ago

/ This might totally be unrelated, I'm new to the rust ecosystem /

I tried to build goose yesterday on NixOS and it already required rust version 1.65 because of the dependency on the time crate. See here:

bebe@gulasch:~/goose$ cargo build --example simple
    Updating crates.io index
  Downloaded rustls-pemfile v1.0.2
  Downloaded hyper-rustls v0.23.2
  Downloaded 2 crates (50.3 KB) in 0.77s
error: package `time v0.3.21` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0

Wouldn't it be appropriate to even tag goose to have rustc version 1.65?

jeremyandrews commented 1 year ago

Yes, that's an excellent point!