search

tag1consulting / goose

Load testing framework, inspired by Locust
https://tag1.com/goose
Apache License 2.0
737 stars 67 forks source link

Duration formatting rounds up to 1 ms #585

Open mpfaff opened 3 months ago

mpfaff commented 3 months ago

Average request time seems unaffected, but minimum request time, (probably) maximum request time, and all response time metrics appear to round up to 1 ms.

jeremyandrews commented 3 months ago

Correct, Goose is tracking requests in milliseconds: https://github.com/tag1consulting/goose/blob/main/src/metrics.rs#L359 https://docs.rs/goose/latest/goose/metrics/struct.GooseRequestMetric.html#structfield.response_time

mpfaff commented 3 months ago

Would you consider using a smaller unit? I think microseconds would still allow Goose to track requests for any reasonable amount of time.

jeremyandrews commented 3 months ago

I'd welcome a PR to make goose more granular! We'd need to do some testing to confirm it doesn't cause any regressions in functionality or performance, and update all the documentation. But it seems an excellent step forward.

flyingmutant commented 2 months ago

Did you consider using HdrHistogram? Looks like it should improve both the accuracy and performance, and take care of the coordinated omission code as well.