#queue_overflow_adapter and #overflow_adapter; Same thing? - Githubissues

taganaka / polipus

Polipus: distributed and scalable web-crawler framework

MIT License

92 stars 32 forks source link

#queue_overflow_adapter and #overflow_adapter; Same thing? #11

Closed tmaier closed 10 years ago

tmaier commented 10 years ago

There's an option :queue_overflow_adapter at Polipus::PolipusCrawler::OPTS and #overflow_adapter.

Latter is defined twice:

attr_reader :overflow_adapter (at https://github.com/taganaka/polipus/blob/d7c44a178dff926170ad7a4642990cc09144dab7/lib/polipus.rb#L78)
def overflow_adapter (at https://github.com/taganaka/polipus/blob/d7c44a178dff926170ad7a4642990cc09144dab7/lib/polipus.rb#L295-L297)

overflow_adapter is not documented and seems not to be used anywhere. I think it is redundant.

taganaka commented 10 years ago

Good catch overflow_adapter looks a stale code! I'll cleanup the code, thanks