search

tagattie / FreeBSD-Electron

Electron port for FreeBSD
76 stars 5 forks source link

net-im/element-desktop: Update to 1.11.68 #155

Closed lwhsu closed 2 months ago

tagattie commented 3 months ago

@lwhsu Can you respond to my review comment before I can merge the proposed change?

I would prefer keeping the identifier if there is no compelling reason.

lwhsu commented 3 months ago

@lwhsu Can you respond to my review comment before I can merge the proposed change?

I'm sorry that I didn't see it. I checked again but still cannot find it. Please point out where it is for me.

I would prefer keeping the identifier if there is no compelling reason.

Do you mean the :prefetch in ${PREFETCH_FILE} of DISTFILES? I hit error of:

The :${group} group used for $file is missing

But I just found it should be due to my Mk/Uses/electron.mk isn't updated. I'll fix this.

tagattie commented 2 months ago

Feedback timeout.