search

tagbase / tagbase-server

tagbase-server is a data management web service for working with eTUFF and nc-eTAG files.
https://oiip.jpl.nasa.gov/doc/OIIP_Deliverable7.4_TagbasePostgreSQLeTUFF_UserGuide.pdf
Apache License 2.0
7 stars 2 forks source link

Refactoring for reducing number of queries #188

Closed renato2099 closed 1 year ago

renato2099 commented 1 year ago

@lewismc this is a small refactoring such that in a second stage we can reduce the number of queries when checking global variables, i..e, instead for 1 SQL query per global attribute we can try to have just a few queries instead. Another advantage is that we can batch the slack messages related to the metadata processing.

renato2099 commented 1 year ago

I will add unit tests for the new two methods once we agree on the current refactoring. I am not sure though if the indentation change shows up as new code being added ? do you know @lewismc ?

lewismc commented 1 year ago

Excellent @renato2099 lets go through this tomorrow. I think this can be merged in after the PR for #181

lewismc commented 1 year ago

I refactored the slack calls. Let's test out on Thursday.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

76.5% 76.5% Coverage
0.0% 0.0% Duplication

renato2099 commented 1 year ago

Hey @lewismc I added a few unit tests I think we should merge this