Configurable emit of message that fails parsing

tagomoris / fluent-plugin-parser

Other

74 stars 23 forks source link

Configurable emit of message that fails parsing #11

Closed vdavidoff closed 10 years ago

vdavidoff commented 10 years ago

Currently if a message fails parsing, it is dropped. This adds the configuration option emit_parse_failures to enable emitting the message even if it fails parsing.

I have tested this in my environment and it appears to be working, though I have only tested with light load.

Thanks for your consideration. Please let me know if you have any questions, or if you think I have gone about this in the wrong way.

tagomoris commented 10 years ago

The feature seems to be done by reserve_data yes. This option reserve raw (source of parser) key-values in output records, even if there are parse errors.

In addition to it, this patch have 2 unacceptable points:

overwrite time and message without any care
Fixed message attribute name is not good for any cases

Please use reserve_data yes.

I'm very sorry for late reply. Thank you for your proposal!

vdavidoff commented 10 years ago

You are correct on all counts. Sorry for the lame pull request. Thanks!