add types support - Githubissues

tagomoris / fluent-plugin-parser

Other

74 stars 23 forks source link

add types support #14

Closed YueHonghui closed 10 years ago

YueHonghui commented 10 years ago

I need types support like fluent-plugin-tail and implement it using fluent-mixin-type-converter. Request to merge to upstream.

tagomoris commented 10 years ago

I cannot merge this pull-request because of some reasons below:

This p-r does not have any tests
I have a plan to use TextParser of recent Fluentd w/ its typecasts

tagomoris commented 10 years ago

See also: #12

YueHonghui commented 10 years ago

I agree with you about the absence of tests. I'm absolutely new to ruby and don't know how to write tests, and just test it in testing environment by feeding large amount of data. Very glad to hear you will support it officially.