Fix forward error: invalid byte sequence in UTF-8 (2nd try)

tagomoris / fluent-plugin-parser

Other

74 stars 23 forks source link

Fix forward error: invalid byte sequence in UTF-8 (2nd try) #3

Closed sonots closed 11 years ago

sonots commented 11 years ago

Continued from the pull request #2.

Now, the invalid byte sequence is replaced with ?, and the replacement occurs only when ArgumentError (invalid byte sequence in ***) is raised. In addition, non-utf8 byte and reserve_data option is supported.

BTW:

I think e.message.index("invalid byte sequence in") == 0 is not a clean code, but I could not find another way to rescue the invalid byte error. Any thoughts?

tagomoris commented 11 years ago

Meged, and add fixes below:

code cleanup: ea4ad46042f0358f7810439e37d15a76fce0879b
set default not to replace invalid chars and add option to enable: 32d4a1ebea926958e0aa859a4c5e56bc38542f3c

Thanks!