search

tagomoris / fluent-plugin-secure-forward

Other
140 stars 30 forks source link

Remove dependency on fluent/mixin/config_placeholders #39

Closed t0ffel closed 8 years ago

t0ffel commented 8 years ago

Hostname placeholder __HOSTNAME__ or ${hostname} will be expanded to #{Socket.gethostname} or to value specified in hostname field.

fixes https://github.com/tagomoris/fluent-plugin-secure-forward/issues/38 Please let me know what you think.

/a bit of offtopic/ When I run with trace on I get a bunch of errors. Although data seem to be getting in. Is that a problem?

2016-06-09 13:36:02 -0400 [trace]: plugin/output_node.rb:347:rescue in block in connect: SSLError error_class=OpenSSL::SSL::SSLErrorWaitReadable error=#<OpenSSL::SSL::SSLErrorWaitReadable: read would block> mtime=2016-06-09 13:35:55 -0400 host="10.3.14.104" port=24284
2016-06-09 13:36:02 -0400 [trace]: plugin/output_node.rb:347:rescue in block in connect: SSLError error_class=OpenSSL::SSL::SSLErrorWaitReadable error=#<OpenSSL::SSL::SSLErrorWaitReadable: read would block> mtime=2016-06-09 13:35:55 -0400 host="10.3.14.104" port=24284
t0ffel commented 8 years ago

@tagomoris can you please take a look?

tagomoris commented 8 years ago

Sorry to miss this. Almost code looks good to me, but it's needed to add tests about hostname placeholders. I'll add some comments about some lines of code.

Trace logs about SSLError are normal for this plugin.

tagomoris commented 8 years ago

I merged #44 instead of merging this pull-request. Thank you for contribution!