Handle the case where the http request errors and there is no response

tagomoris / presto-client-node

Distributed query engine Presto client library for node.js

MIT License

126 stars 57 forks source link

Closed snoble closed 8 years ago

snoble commented 8 years ago

I know this is old code but there's a minor bug. If the http request fails then only an error is sent to the callback here: https://github.com/snoble/presto-client-node/blob/master/lib/presto-client/index.js#L69, which leads to attempting to call error on undefined.

tagomoris commented 8 years ago

LGTM. Nice!

snoble commented 8 years ago

Thanks!