search

tagomoris / presto-client-node

Distributed query engine Presto client library for node.js
MIT License
125 stars 57 forks source link

Add CI tests for the library #68

Closed MasterOdin closed 1 year ago

MasterOdin commented 1 year ago

Adding tests / CI was mentioned in #50, but I'm splitting this off into its own issue as I feel like this could be accomplished without also converting the library to TS.

Having a test suite that could be run against the library would be awesome. To accomplish this, my suggestion would be to utilize the testcontainers library to spin up a presto/trino container + postgres container that are networked together, and then can just run through the basics of the existing client methods. With this in place, would be easy to extend over time with more complex configurations.

Happy to contribute to this effort @tagomoris if a PR would be accepted following the above plan (or if you've got some other idea of how to do it).

tagomoris commented 1 year ago

@MasterOdin That sounds great. It's the thing I want to have if I have time. Contribution in that area is really nice to have. If I could say what's the best, it's better to have docker-compose.yml too to test that combination locally.